lkml.org 
[lkml]   [2021]   [Apr]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe:Re: [PATCH] drm/amd/display: Remove duplicate include of hubp.h
From
Date

>Nice catch!
>
>Are you using any tool to identify this problem?

Yes, I have a robot including many detecting scripts :)

>Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
>
>On 04/29, Wan Jiabing wrote:
>> In commit 482812d56698e ("drm/amd/display: Set max TTU on
>> DPG enable"), "hubp.h" was added which caused the duplicate include.
>> To be on the safe side, remove the later duplicate include.
>>
>> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
>> ---
>> drivers/gpu/drm/amd/display/dc/core/dc.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c
>> index 8f0a13807d05..dcaa6b1e16af 100644
>> --- a/drivers/gpu/drm/amd/display/dc/core/dc.c
>> +++ b/drivers/gpu/drm/amd/display/dc/core/dc.c
>> @@ -58,7 +58,6 @@
>> #include "dc_link_ddc.h"
>> #include "dm_helpers.h"
>> #include "mem_input.h"
>> -#include "hubp.h"
>>
>> #include "dc_link_dp.h"
>> #include "dc_dmub_srv.h"
>> --
>> 2.25.1
>>
>
>--
>Rodrigo Siqueira
>https://siqueira.tech

Yours,
Wan Jiabing

\
 
 \ /
  Last update: 2021-04-29 14:32    [W:1.363 / U:0.328 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site