Messages in this thread | | | Date | Thu, 29 Apr 2021 11:24:39 +0200 | From | Petr Mladek <> | Subject | Re: [PATCH 2/4] lib/vsprintf.c: Make %p{D,d} mean as much components as possible |
| |
On Thu 2021-04-29 11:52:49, Andy Shevchenko wrote: > On Thu, Apr 29, 2021 at 11:47 AM Petr Mladek <pmladek@suse.com> wrote: > > > > On Wed 2021-04-28 21:59:27, Jia He wrote: > > > From: Linus Torvalds <torvalds@linux-foundation.org> > > > > > > We have '%pD'(no digit following) for printing a filename. It may not be > > > perfect (by default it only prints one component. > > > > > > %pD4 should be more than good enough, but we should make plain "%pD" mean > > > "as much of the path that is reasonable" rather than "as few components as > > > possible" (ie 1). > > > > Could you please provide link to the discussion where this idea was > > came from? > > https://lore.kernel.org/lkml/20210427025805.GD3122264@magnolia/
Thanks for the link. I see that it was not clear whether the patch was good for %pd behavior.
Linus actually suggests to keep %pd behavior as it was before, see https://lore.kernel.org/lkml/CAHk-=wimsMqGdzik187YWLb-ru+iktb4MYbMQG1rnZ81dXYFVg@mail.gmail.com/
Well, I think that this is up to the file system developers to decide. I am not sure if the path would do more harm than good, or vice versa, for dentry names.
Best Regards, Petr
| |