Messages in this thread | | | Subject | Re: [PATCH v2] samples/landlock: fix path_list memory leak | From | Mickaël Salaün <> | Date | Thu, 29 Apr 2021 11:22:06 +0200 |
| |
On 28/04/2021 23:38, trix@redhat.com wrote: > From: Tom Rix <trix@redhat.com> > > Clang static analysis reports this error > > sandboxer.c:134:8: warning: Potential leak of memory > pointed to by 'path_list' > ret = 0; > ^ > path_list is allocated in parse_path() but never freed. > > Signed-off-by: Tom Rix <trix@redhat.com>
Reviewed-by: Mickaël Salaün <mic@linux.microsoft.com>
Previous version: https://lore.kernel.org/r/20210427183755.2790654-1-trix@redhat.com
> --- > v2: > - Remove NULL ptr check > --- > samples/landlock/sandboxer.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/samples/landlock/sandboxer.c b/samples/landlock/sandboxer.c > index 7a15910d2171..8859fc193542 100644 > --- a/samples/landlock/sandboxer.c > +++ b/samples/landlock/sandboxer.c > @@ -134,6 +134,7 @@ static int populate_ruleset( > ret = 0; > > out_free_name: > + free(path_list); > free(env_path_name); > return ret; > } >
| |