Messages in this thread | | | Date | Thu, 29 Apr 2021 09:38:02 +0200 | From | Mauro Carvalho Chehab <> | Subject | Re: [PATCH v4 20/79] staging: media: rkvdec: fix pm_runtime_get_sync() usage count |
| |
Em Wed, 28 Apr 2021 17:09:57 +0200 Johan Hovold <johan@kernel.org> escreveu:
> On Wed, Apr 28, 2021 at 04:51:41PM +0200, Mauro Carvalho Chehab wrote: > > The pm_runtime_get_sync() internally increments the > > dev->power.usage_count without decrementing it, even on errors. > > Replace it by the new pm_runtime_resume_and_get(), introduced by: > > commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter") > > in order to properly decrement the usage counter and avoid memory > > leaks. > > Again, there is no memory leak here either. Just a potential PM usage > counter leak.
True. Will fix it at the entire series with:
FILTER_BRANCH_SQUELCH_WARNING=1 git filter-branch -f --msg-filter "cat|perl -0pe 's/ and avoid memory\n\s*leaks./, avoiding\na potential PM usage counter leak./igs'" BASE..
Regards, Mauro
| |