Messages in this thread | | | Date | Wed, 28 Apr 2021 11:34:16 +0530 | From | skakit@codeauro ... | Subject | Re: [RESEND PATCH V3 5/5] arm64: dts: qcom: sc7280: Include PMIC DT files for sc7280 |
| |
On 2021-04-20 23:32, Matthias Kaehlcke wrote: > On Wed, Apr 14, 2021 at 04:43:03PM +0530, satya priya wrote: > >> Subject: arm64: dts: qcom: sc7280: Include PMIC DT files for sc7280 > > Please make sure to distinguish between the SoC (sc7280) and the > board (sc7280-idp), this patch primarily adds stuff to the board not > the SoC, this should be clear from the subject. >
Sure, will mention sc7280-idp in the subject.
>> Include pm7325, pm8350c, pmk8350 and pmr735a DT files. > > How about something like 'The sc7280-idp has four PMICs, include their > .dtsi files'? >
Okay.
>> Add channel nodes for pmk8350_vadc. > > It's not super important, but I don't like it when things like this get > sneaked in with a commit message saying 'Include PMIC DT files for > sc7280'. I would suggest a separate patch. And please mention that > the channels are for the on die temperatures of the PMICs. >
Okay, will make a separate patch for adding channel nodes.
>> Also, add the thermal_zones node in dtsi. > > This is not the right patch to add it. This patch is about the > sc7280-board > and doesn't do anything (directly) with thermal zones. However other > patches further down in the stack of in this series require the > 'thermal-zones' to exist, hence the node should exist before these > patches > reference it. A dedicated patch adding the node seems like the best > option > to me.
Okay, I will add a separate patch for adding thermal-zones node and place it in the beginning of the series.
Thanks, Satya Priya
| |