Messages in this thread | | | Date | Wed, 28 Apr 2021 18:54:16 +0800 | From | fenglinw@codeauro ... | Subject | Re: [PATCH 1/2] dt-bindings: pwm: add bindings for PWM modules inside QCOM PMICs |
| |
On 2021-04-27 20:57, Rob Herring wrote: > On Tue, 27 Apr 2021 18:22:09 +0800, Fenglin Wu wrote: >> Add bindings for QCOM PMIC PWM modules which are accessed through SPMI >> bus. >> >> Signed-off-by: Fenglin Wu <fenglinw@codeaurora.org> >> --- >> .../devicetree/bindings/pwm/pwm-qcom.yaml | 51 >> ++++++++++++++++++++++ >> 1 file changed, 51 insertions(+) >> create mode 100644 >> Documentation/devicetree/bindings/pwm/pwm-qcom.yaml >> > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > ./Documentation/devicetree/bindings/pwm/pwm-qcom.yaml:29:6: [warning] > wrong indentation: expected 4 but found 5 (indentation) > > dtschema/dtc warnings/errors: > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pwm/pwm-qcom.yaml: > Additional properties are not allowed ('Properties' was unexpected) > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pwm/pwm-qcom.yaml: > Additional properties are not allowed ('Properties' was unexpected) > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pwm/pwm-qcom.yaml: > 'anyOf' conditional failed, one must be fixed: > 'properties' is a required property > 'patternProperties' is a required property > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pwm/pwm-qcom.yaml: > ignoring, error in schema: > warning: no schema found in file: > ./Documentation/devicetree/bindings/pwm/pwm-qcom.yaml > Documentation/devicetree/bindings/pwm/pwm-qcom.example.dts:21.13-28: > Warning (reg_format): /example-0/pwms@e800:reg: property has invalid > length (4 bytes) (#address-cells == 1, #size-cells == 1) > Documentation/devicetree/bindings/pwm/pwm-qcom.example.dt.yaml: > Warning (pci_device_reg): Failed prerequisite 'reg_format' > Documentation/devicetree/bindings/pwm/pwm-qcom.example.dt.yaml: > Warning (pci_device_bus_num): Failed prerequisite 'reg_format' > Documentation/devicetree/bindings/pwm/pwm-qcom.example.dt.yaml: > Warning (simple_bus_reg): Failed prerequisite 'reg_format' > Documentation/devicetree/bindings/pwm/pwm-qcom.example.dt.yaml: > Warning (i2c_bus_reg): Failed prerequisite 'reg_format' > Documentation/devicetree/bindings/pwm/pwm-qcom.example.dt.yaml: > Warning (spi_bus_reg): Failed prerequisite 'reg_format' > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pwm/pwm-qcom.example.dt.yaml: > example-0: pwms@e800:reg:0: [59392] is too short > From schema: > /usr/local/lib/python3.8/dist-packages/dtschema/schemas/reg.yaml > Documentation/devicetree/bindings/pwm/pwm-qcom.example.dt.yaml:0:0: > /example-0/pwms@e800: failed to match any schema with compatible: > ['qcom,pwm'] > > See https://patchwork.ozlabs.org/patch/1470623 > > This check can fail if there are any dependencies. The base for a patch > series is generally the most recent rc1. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit.
Thanks for the information. It's my 1st time to write binding using yaml format, I hadn't noticed there was a checker can be used for sanity test. I will update and run the dt_binding_check at my side before uploading new patchset.
| |