Messages in this thread | | | Subject | Re: [PATCH 6/6] KVM: x86/mmu: Lazily allocate memslot rmaps | From | Paolo Bonzini <> | Date | Wed, 28 Apr 2021 12:03:52 +0200 |
| |
On 28/04/21 00:36, Ben Gardon wrote: > -static int kvm_alloc_memslot_metadata(struct kvm_memory_slot *slot, > +static int kvm_alloc_memslot_metadata(struct kvm *kvm, > + struct kvm_memory_slot *slot, > unsigned long npages) > { > int i; > @@ -10892,7 +10950,7 @@ static int kvm_alloc_memslot_metadata(struct kvm_memory_slot *slot, > */ > memset(&slot->arch, 0, sizeof(slot->arch)); > > - r = alloc_memslot_rmap(slot, npages); > + r = alloc_memslot_rmap(kvm, slot, npages); > if (r) > return r; >
I wonder why you need alloc_memslot_rmap at all here in kvm_alloc_memslot_metadata, or alternatively why you need to do it in kvm_arch_assign_memslots. It seems like only one of those would be necessary.
Paolo
| |