Messages in this thread | | | Date | Tue, 27 Apr 2021 08:56:33 -0700 | From | Richard Cochran <> | Subject | Re: [net-next, v2, 3/7] net: dsa: free skb->cb usage in core driver |
| |
On Mon, Apr 26, 2021 at 09:39:44PM +0300, Vladimir Oltean wrote: > On Mon, Apr 26, 2021 at 06:38:46AM -0700, Richard Cochran wrote: > > On Mon, Apr 26, 2021 at 05:37:58PM +0800, Yangbo Lu wrote: > > > @@ -624,7 +623,7 @@ static netdev_tx_t dsa_slave_xmit(struct sk_buff *skb, struct net_device *dev) > > > > > > dev_sw_netstats_tx_add(dev, 1, skb->len); > > > > > > - DSA_SKB_CB(skb)->clone = NULL; > > > + memset(skb->cb, 0, 48); > > > > Replace hard coded 48 with sizeof() please. > > You mean just a trivial change like this, right? > > memset(skb->cb, 0, sizeof(skb->cb));
Yes.
Thanks, Richard
| |