Messages in this thread | | | Subject | Re: [PATCH v2] clk: Skip clk provider registration when np is NULL | From | nicolas saenz julienne <> | Date | Tue, 27 Apr 2021 16:57:30 +0200 |
| |
On Mon, 2021-04-26 at 09:56 +0300, Tudor Ambarus wrote: > commit 6579c8d97ad7 ("clk: Mark fwnodes when their clock provider is added") > revealed that clk/bcm/clk-raspberrypi.c driver calls > devm_of_clk_add_hw_provider(), with a NULL dev->of_node, which resulted in a > NULL pointer dereference in of_clk_add_hw_provider() when calling > fwnode_dev_initialized(). > > Returning 0 is reducing the if conditions in driver code and is being > consistent with the CONFIG_OF=n inline stub that returns 0 when CONFIG_OF > is disabled. The downside is that drivers will maybe register clkdev lookups > when they don't need to and waste some memory. > > Reported-by: Marek Szyprowski <m.szyprowski@samsung.com> > Fixes: 6579c8d97ad7 ("clk: Mark fwnodes when their clock provider is added") > Fixes: 3c9ea42802a1 ("clk: Mark fwnodes when their clock provider is added/removed") > Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com> > Reviewed-by: Stephen Boyd <sboyd@kernel.org> > ---
Reviewed-by: Nicolas Saenz Julienne <nsaenz@kernel.org>
Regards, Nicolas
| |