Messages in this thread | | | Subject | Re: [PATCH v3] media:exynos4-is: Fix a use after free in isp_video_release | From | Sylwester Nawrocki <> | Date | Tue, 27 Apr 2021 15:48:15 +0200 |
| |
On 27.04.2021 15:27, Lv Yunlong wrote: > In isp_video_release, file->private_data is freed via > _vb2_fop_release()->v4l2_fh_release(). But the freed > file->private_data is still used in v4l2_fh_is_singular_file() > ->v4l2_fh_is_singular(file->private_data), which is a use > after free bug. > > My patch sets file->private_data to NULL after _vb2_fop_release() > to avoid the use after free, and uses a variable 'is_singular_file' > to keep the original function unchanged. > > Fixes: 34947b8aebe3f ("[media] exynos4-is: Add the FIMC-IS ISP capture DMA driver") > Signed-off-by: Lv Yunlong <lyl2019@mail.ustc.edu.cn>
Thanks,
Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
| |