| From | Geert Uytterhoeven <> | Date | Tue, 27 Apr 2021 12:34:27 +0200 | Subject | Re: [PATCH v3 78/79] media: rcar-vin: use pm_runtime_resume_and_get() |
| |
On Tue, Apr 27, 2021 at 12:28 PM Mauro Carvalho Chehab <mchehab+huawei@kernel.org> wrote: > Commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter") > added pm_runtime_resume_and_get() in order to automatically handle > dev->power.usage_count decrement on errors. > > Use the new API, in order to cleanup the error check logic. > > Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> --- a/drivers/media/platform/rcar-vin/rcar-csi2.c > +++ b/drivers/media/platform/rcar-vin/rcar-csi2.c > @@ -408,6 +408,12 @@ static void rcsi2_enter_standby(struct rcar_csi2 *priv) > > static void rcsi2_exit_standby(struct rcar_csi2 *priv) > { > + /* > + * The code at rcsi2_enter_standby() assumes > + * inconditionally that PM runtime usage count was
unconditionally
> + * incremented. So, it shouldn't use pm_runtime_resume_and_get() > + * here. > + */ > pm_runtime_get_sync(priv->dev); > reset_control_deassert(priv->rstc); > }
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
|