Messages in this thread | | | Date | Tue, 27 Apr 2021 08:55:38 +0100 | From | Mel Gorman <> | Subject | Re: [PATCH] sched/fair: Fix unsetting of "has_idle_cores" flag |
| |
On Mon, Apr 26, 2021 at 10:34:12PM +0530, Gautham R. Shenoy wrote: > From: "Gautham R. Shenoy" <ego@linux.vnet.ibm.com> > > In commit 9fe1f127b913 ("sched/fair: Merge select_idle_core/cpu()"), in > select_idle_cpu(), we check if an idle core is present in the LLC of the > target CPU via the flag "has_idle_cores". We look for the idle core in > select_idle_cores(). If select_idle_cores() isn't able to find an idle > core/CPU, we need to unset the has_idle_cores flag in the LLC of the > target to prevent other CPUs from going down this route. > > However, the current code is unsetting it in the LLC of the current CPU > instead of the target CPU. This patch fixes this issue. > > Fixes: Commit 9fe1f127b913 ("sched/fair: Merge select_idle_core/cpu()") > Cc: Mel Gorman <mgorman@techsingularity.net> > Signed-off-by: Gautham R. Shenoy <ego@linux.vnet.ibm.com>
Acked-by: Mel Gorman <mgorman@techsingularity.net>
-- Mel Gorman SUSE Labs
| |