Messages in this thread | | | From | Heiko Stübner <> | Subject | Re: [PATCH v2 6/7] arm64: dts: rockchip: add core dtsi for RK3568 SoC | Date | Tue, 27 Apr 2021 09:48:41 +0200 |
| |
Hi,
Am Dienstag, 27. April 2021, 05:45:03 CEST schrieb Kever Yang: > Hi Johan, Heiko, > > On 2021/4/26 下午8:16, Johan Jonker wrote: > > === > > > > compatible = "rockchip,rk3568"; > > Maybe add this together with other rkXXXX SoCs to rockchip.yaml on top > > of board list ??? > > Please advise.
I don't think so. I.e. the rockchip,rk3568 compatible is not supposed be standing alone somewhere, but should always be combined with a board- compatible. Same as the rk3568.dtsi should not be used alone but included into a board dts.
And patch7 does this by adding the necessary entry to the board list.
> This rockchip.yaml is now describe boards without any sort, it would be > better to refactor and sort in two level: > - soc level > - board level base on the same soc.
The sorting in rockchip.yaml is supposed to be alphabetically by description. (vendor + boardname)
My intention for this was to allow readers to find their board to get the matching compatible - and I like that ordering somehow ;-) .
So I don't think there are bigger changes necessary to rockchip.yaml
Heiko
| |