lkml.org 
[lkml]   [2021]   [Apr]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v6 3/3] pinctrl: Add Xilinx ZynqMP pinctrl driver support
From
Date
Hi Andy,

On 4/26/21 4:04 PM, Andy Shevchenko wrote:
> On Mon, Apr 26, 2021 at 4:20 PM Sai Krishna Potthuri
> <lakshmis@xilinx.com> wrote:
>>> From: Andy Shevchenko <andy.shevchenko@gmail.com>
>>> Sent: Friday, April 23, 2021 9:24 PM
>>> On Thu, Apr 22, 2021 at 11:31 AM Sai Krishna Potthuri
>>> <lakshmi.sai.krishna.potthuri@xilinx.com> wrote:
>
> ...
>
>>>> +config PINCTRL_ZYNQMP
>>>> + tristate "Pinctrl driver for Xilinx ZynqMP"
>>>> + depends on ZYNQMP_FIRMWARE
>>>> + select PINMUX
>>>> + select GENERIC_PINCONF
>>>> + default ZYNQMP_FIRMWARE
>>>> + help
>>>> + This selects the pinctrl driver for Xilinx ZynqMP platform.
>>>> + This driver will query the pin information from the firmware
>>>> + and allow configuring the pins.
>>>> + Configuration can include the mux function to select on those
>>>> + pin(s)/group(s), and various pin configuration parameters
>>>> + such as pull-up, slew rate, etc.
>>>
>>> Missed module name.
>> Is this (module name) a configuration option in Kconfig?
>
> It's a text in a free form that sheds light on how the module will be
> named in case the user will choose "m".

Is this described somewhere in documentation that module name should be
the part of symbol description? I was looking at pinctrl Kconfig and I
can't see any description like this there that's why I want to double
check.

Also if this is a rule checkpatch should be extended to checking this.

Thanks,
Michal

\
 
 \ /
  Last update: 2021-04-27 09:26    [W:0.128 / U:0.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site