Messages in this thread | | | Subject | Re: [PATCH] [v2] rtc: bd70528: fix BD71815 watchdog dependency | From | Randy Dunlap <> | Date | Tue, 27 Apr 2021 18:39:32 -0700 |
| |
On 4/22/21 8:15 AM, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@arndb.de> > > The added Kconfig dependency is slightly incorrect, which can > lead to a link failure when the watchdog is a loadable module: > > arm-linux-gnueabi-ld: drivers/rtc/rtc-bd70528.o: in function `bd70528_set_rtc_based_timers': > rtc-bd70528.c:(.text+0x6cc): undefined reference to `bd70528_wdt_set' > arm-linux-gnueabi-ld: drivers/rtc/rtc-bd70528.o: in function `bd70528_set_time': > rtc-bd70528.c:(.text+0xaa0): undefined reference to `bd70528_wdt_lock' > arm-linux-gnueabi-ld: rtc-bd70528.c:(.text+0xab8): undefined reference to `bd70528_wdt_unlock' > arm-linux-gnueabi-ld: drivers/rtc/rtc-bd70528.o: in function `bd70528_alm_enable': > rtc-bd70528.c:(.text+0xfc0): undefined reference to `bd70528_wdt_lock' > arm-linux-gnueabi-ld: rtc-bd70528.c:(.text+0x1030): undefined reference to `bd70528_wdt_unlock' > > The problem is that it allows to be built-in if MFD_ROHM_BD71828 > is built-in, even when the watchdog is a loadable module. > > Rework this so that having the watchdog as a loadable module always > forces the rtc to be a module as well instead of built-in, > regardless of bd71828. > > Fixes: c56dc069f268 ("rtc: bd70528: Support RTC on ROHM BD71815") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > v2: Fix as suggested by Guenter Roeck, reword description > --- > drivers/rtc/Kconfig | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig > index d8c13fded164..914497abeef9 100644 > --- a/drivers/rtc/Kconfig > +++ b/drivers/rtc/Kconfig > @@ -502,7 +502,8 @@ config RTC_DRV_M41T80_WDT > > config RTC_DRV_BD70528 > tristate "ROHM BD70528, BD71815 and BD71828 PMIC RTC" > - depends on MFD_ROHM_BD71828 || MFD_ROHM_BD70528 && (BD70528_WATCHDOG || !BD70528_WATCHDOG) > + depends on MFD_ROHM_BD71828 || MFD_ROHM_BD70528 > + depends on BD70528_WATCHDOG || !BD70528_WATCHDOG > help > If you say Y here you will get support for the RTC > block on ROHM BD70528, BD71815 and BD71828 Power Management IC. >
Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
thanks.
-- ~Randy
| |