Messages in this thread | | | Subject | Re: [GIT PULL][PATCH v10 0/4] Update to zstd-1.4.10 | From | Randy Dunlap <> | Date | Tue, 27 Apr 2021 15:09:59 -0700 |
| |
On 4/26/21 4:46 PM, Nick Terrell wrote: > From: Nick Terrell <terrelln@fb.com> > > Please pull from > > git@github.com:terrelln/linux.git tags/v10-zstd-1.4.10 > > to get these changes. Alternatively the patchset is included. > > This patchset lists me as the maintainer for zstd and upgrades the zstd library > to the latest upstream release. The current zstd version in the kernel is a > modified version of upstream zstd-1.3.1. At the time it was integrated, zstd > wasn't ready to be used in the kernel as-is. But, it is now possible to use > upstream zstd directly in the kernel.
Hi Nick,
Several of the source (.c, .h) files use comments blocks that begin with "/**", which means "this is the beginning of a kernel-doc comment" when in the kernel source tree. However, they are not in kernel-doc format.
During the automatic generation from upstream zstd, please find a way to change /** to /*.
This does need to slow down the acceptance of this patch series IMO.
thanks. -- ~Randy
| |