Messages in this thread | | | Date | Tue, 27 Apr 2021 21:57:27 +0200 | From | Christoph Hellwig <> | Subject | Re: [GIT PULL] iomap: new code for 5.13-rc1 |
| |
On Tue, Apr 27, 2021 at 12:40:09PM -0700, Linus Torvalds wrote: > We have '%pD' for printing a filename. It may not be perfect (by > default it only prints one component, you can do "%pD4" to show up to > four components), but it should "JustWork(tm)". > > And if it doesn't, we should fix it. > > So instead of having a kmalloc/kfree for the path buffer, I think you > should have been able to just do > > pr_err("swapon: file %pD4 %s\n", isi->file, str); > > and be done with it.
I'm aware of %pD, but 4 components here are not enough. People need to distinguish between xfstests runs and something real in the system for these somewhat scary sounding messages.
| |