Messages in this thread | | | From | Nick Desaulniers <> | Date | Tue, 27 Apr 2021 11:54:17 -0700 | Subject | Re: [PATCH] fs/ntfs: drop unneeded assignment in ntfs_perform_write() |
| |
On Sun, Apr 25, 2021 at 3:16 AM Yang Li <yang.lee@linux.alibaba.com> wrote: > > It is not required to initialize the local variable idx in > ntfs_perform_write(), the value is never actually read from > it. > > make clang-analyzer on x86_64 allyesconfig reports: > > fs/ntfs/file.c:1781:15: warning: Although the value stored to 'idx' is > used in the enclosing expression, the value is never actually read from > 'idx' > > Simplify the code and remove unneeded assignment to make clang-analyzer > happy.
Thank you for the patch. Reviewed-by: Nick Desaulniers <ndesaulniers@google.com> Is there someplace where I can learn more about "Abaci Robot?" I'm happy to see it running clang-analyzer. :)
> > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> > --- > fs/ntfs/file.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/fs/ntfs/file.c b/fs/ntfs/file.c > index e5aab26..e39a26f 100644 > --- a/fs/ntfs/file.c > +++ b/fs/ntfs/file.c > @@ -1774,11 +1774,11 @@ static ssize_t ntfs_perform_write(struct file *file, struct iov_iter *i, > last_vcn = -1; > do { > VCN vcn; > - pgoff_t idx, start_idx; > + pgoff_t start_idx; > unsigned ofs, do_pages, u; > size_t copied; > > - start_idx = idx = pos >> PAGE_SHIFT; > + start_idx = pos >> PAGE_SHIFT; > ofs = pos & ~PAGE_MASK; > bytes = PAGE_SIZE - ofs; > do_pages = 1; > -- > 1.8.3.1 > > -- > You received this message because you are subscribed to the Google Groups "Clang Built Linux" group. > To unsubscribe from this group and stop receiving emails from it, send an email to clang-built-linux+unsubscribe@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/clang-built-linux/1619345754-32875-1-git-send-email-yang.lee%40linux.alibaba.com.
-- Thanks, ~Nick Desaulniers
| |