Messages in this thread | | | Subject | Re: [PATCH net-next v7 3/9] net: dsa: microchip: ksz8795: move register offsets and shifts to separate struct | From | Florian Fainelli <> | Date | Mon, 26 Apr 2021 11:32:10 -0700 |
| |
On 4/26/21 6:19 AM, Oleksij Rempel wrote: > From: Michael Grzeschik <m.grzeschik@pengutronix.de> > > In order to get this driver used with other switches the functions need > to use different offsets and register shifts. This patch changes the > direct use of the register defines to register description structures, > which can be set depending on the chips register layout. > > Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de> > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> > Reviewed-by: Andrew Lunn <andrew@lunn.ch>
The changes look fine, however ther are 32-bit build errors with this specific patch:
https://patchwork.kernel.org/project/netdevbpf/patch/20210426131911.25976-4-o.rempel@pengutronix.de/ https://patchwork.hopto.org/static/nipa/473275/12224263/build_32bit/stderr -- Florian
| |