Messages in this thread | | | Subject | Re: [RFC] bpf.2: Use standard types and attributes | From | "Alejandro Colomar (man-pages)" <> | Date | Mon, 26 Apr 2021 19:46:48 +0200 |
| |
Hi Joseph,
On 4/26/21 7:19 PM, Joseph Myers wrote: > On Sat, 24 Apr 2021, Alejandro Colomar via Libc-alpha wrote: > >> Some pages also document attributes, using GNU syntax >> '__attribute__((xxx))'. Update those to use the shorter and more >> portable C2x syntax, which hasn't been standardized yet, but is >> already implemented in GCC, and available through either --std=c2x >> or any of the --std=gnu... options. > > If you mention alignment in the manpage at all, the same reasoning would > say you should use _Alignas(8) not [[gnu::aligned(8)]], in any context > where _Alignas is valid. >
Agree.
I just didn't know 'alignas()' (a.k.a. '_Alignas()'), so I used attributes and only changed the syntax. But yes, we should use that C11 feature. Given that we already used 'noreturn' and not '_Noreturn' (see exit(3) and its family), I'll use 'alignas()'.
I'll send a v2 with those changes.
Thanks,
Alex
-- Alejandro Colomar Linux man-pages comaintainer; https://www.kernel.org/doc/man-pages/ http://www.alejandro-colomar.es/
| |