Messages in this thread | | | Date | Mon, 26 Apr 2021 18:21:06 +0200 | From | Greg KH <> | Subject | Re: [PATCH] Staging:ipack/carriers/tpci200: Fix a double free in tpci200_pci_probe |
| |
On Mon, Apr 26, 2021 at 08:35:47AM -0700, Lv Yunlong wrote: > In the out_err_bus_register error branch of tpci200_pci_probe, > tpci200->info->cfg_regs is freed by tpci200_uninstall()-> > tpci200_unregister()->pci_iounmap(..,tpci200->info->cfg_regs) > in the first time. > > But later, iounmap() is called to free tpci200->info->cfg_regs > again. > > My patch sets tpci200->info->cfg_regs to NULL after tpci200_uninstall() > to avoid the double free. > > Fixes: cea2f7cdff2af ("Staging: ipack/bridges/tpci200: Use the TPCI200 in big endian mode") > Signed-off-by: Lv Yunlong <lyl2019@mail.ustc.edu.cn> > --- > drivers/ipack/carriers/tpci200.c | 5 ++++-
This is not a staging driver, why does your subject line say that?
thanks,
greg k-h
| |