lkml.org 
[lkml]   [2021]   [Apr]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] ARC: Use max_high_pfn as a HIGHMEM zone border
On Mon, Apr 26, 2021 at 11:55:00AM +0000, Vladimir Isaev wrote:
> Hi Mike,
>
> On Mon, April 26, 2021 2:29 PM, Mike Rapoport wrote:
> > On Mon, Apr 26, 2021 at 01:10:04PM +0300, Vladimir Isaev wrote:
> > > - max_zone_pfn[ZONE_HIGHMEM] = min_low_pfn;
> > > + max_zone_pfn[ZONE_HIGHMEM] = max_high_pfn;
> >
> > This is correct with PAE40, but it will break !PAE40 when "highmem" has lower
> > addresses than lowmem.
> >
> > It rather should be something like:
> >
> > if (IS_ENABLED(CONFIG_ARC_HAS_PAE40))
> > max_zone_pfn[ZONE_HIGHMEM] = max_high_pfn;
> > else
> > max_zone_pfn[ZONE_HIGHMEM] = min_low_pfn;
> >
>
> Not sure if I understand why we should have min_low_pfn here. In !PAE40
> case max_high_pfn just will be smaller than min_low_pfn.

Hmm, actually, you are right. This should be fine.

--
Sincerely yours,
Mike.

\
 
 \ /
  Last update: 2021-04-26 18:17    [W:0.120 / U:0.176 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site