Messages in this thread | | | Date | Mon, 26 Apr 2021 09:47:08 -0500 | From | Nishanth Menon <> | Subject | Re: [PATCH v2] soc: ti: smartreflex after the relocation to maintain consistency |
| |
On 19:16-20210422, Yang Li wrote: > v2: According to Nishanth Menon's suggestion, the subject has been > corrected. > https://lore.kernel.org/patchwork/patch/1383883/
The above does'nt belong to commit message. it should probably be posted in diffstat section.
will also be good to rebase once 5.13-rc1 is out. > > Fix the following coccicheck warning: > ./drivers/soc/ti/smartreflex.c:820:0-23: WARNING: pm_sr_fops should be > defined with DEFINE_DEBUGFS_ATTRIBUTE > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> > Reviewed-by: Nishanth Menon <nm@ti.com> > --- > drivers/soc/ti/smartreflex.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/soc/ti/smartreflex.c b/drivers/soc/ti/smartreflex.c > index 5376f3d..b3c7460 100644 > --- a/drivers/soc/ti/smartreflex.c > +++ b/drivers/soc/ti/smartreflex.c > @@ -817,7 +817,7 @@ static int omap_sr_autocomp_store(void *data, u64 val) > return 0; > } > > -DEFINE_SIMPLE_ATTRIBUTE(pm_sr_fops, omap_sr_autocomp_show, > +DEFINE_DEBUGFS_ATTRIBUTE(pm_sr_fops, omap_sr_autocomp_show, > omap_sr_autocomp_store, "%llu\n"); > > static int omap_sr_probe(struct platform_device *pdev) > -- > 1.8.3.1 >
-- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
| |