Messages in this thread | | | From | Thomas Gleixner <> | Subject | Re: [PATCH] hrtimer: Avoid double reprogramming in __hrtimer_start_range_ns() | Date | Mon, 26 Apr 2021 16:27:08 +0200 |
| |
On Mon, Apr 26 2021 at 14:40, Peter Zijlstra wrote:
> On Mon, Apr 26, 2021 at 02:33:00PM +0200, Thomas Gleixner wrote: > >> >> + force_local = base->cpu_base == this_cpu_ptr(&hrtimer_bases); >> >> + force_local &= base->cpu_base->next_timer == timer; >> > >> > Using bitwise ops on a bool is cute and all, but isn't that more >> > readable when written like: >> > >> > force_local = base->cpu_base == this_cpu_ptr(&hrtimer_bases) && >> > base->cpu_base->next_timer == timer; >> > >> >> Which results in an extra conditional branch. > > Srlsy, compiler not smart enough?
gcc 8.3 is definitely not ...
| |