lkml.org 
[lkml]   [2021]   [Apr]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] hrtimer: Avoid double reprogramming in __hrtimer_start_range_ns()
On Mon, Apr 26, 2021 at 02:33:00PM +0200, Thomas Gleixner wrote:

> >> + force_local = base->cpu_base == this_cpu_ptr(&hrtimer_bases);
> >> + force_local &= base->cpu_base->next_timer == timer;
> >
> > Using bitwise ops on a bool is cute and all, but isn't that more
> > readable when written like:
> >
> > force_local = base->cpu_base == this_cpu_ptr(&hrtimer_bases) &&
> > base->cpu_base->next_timer == timer;
> >
>
> Which results in an extra conditional branch.

Srlsy, compiler not smart enough?

\
 
 \ /
  Last update: 2021-04-26 14:42    [W:0.080 / U:0.228 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site