lkml.org 
[lkml]   [2021]   [Apr]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH] drivers: pnp: proc.c: Removed unnecessary varibles
    On Mon, Apr 26, 2021 at 6:57 AM Leon Romanovsky <leon@kernel.org> wrote:
    >
    > On Fri, Apr 23, 2021 at 03:08:03PM -0600, Shuah Khan wrote:
    > > On 4/22/21 12:03 PM, Anupama K Patil wrote:
    > > > de, e are two variables of the type 'struct proc_dir_entry'
    > > > which can be removed to save memory. This also fixes a coding style
    > > > issue reported by checkpatch where we are suggested to make assignment
    > > > outside the if statement.
    > > >
    > >
    > > Sounds like a reasonable change.
    >
    > It is unclear how much changes to ISA code are welcomed.

    Real fixes and obvious cleanups are, not much more than that.

    > According to the Wikipedia, even Windows Vista disabled ISA PnP by default.
    > https://en.wikipedia.org/wiki/Legacy_Plug_and_Play#Specifications

    It is indeed unclear how many systems with this interface still run
    Linux, but as long as the code is in the tree, there's nothing wrong
    with attempting to improve it. There's no assurance that all such
    patches will be applied, though.

    Thanks!

    \
     
     \ /
      Last update: 2021-04-26 14:02    [W:3.268 / U:0.276 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site