Messages in this thread | | | From | Masahiro Yamada <> | Date | Mon, 26 Apr 2021 19:40:24 +0900 | Subject | Re: [PATCH 3/4] crypto: arm64: generate *.S by Perl at build time instead of shipping them |
| |
On Mon, Apr 26, 2021 at 6:01 PM Ard Biesheuvel <ardb@kernel.org> wrote: > > On Mon, 26 Apr 2021 at 10:58, Will Deacon <will@kernel.org> wrote: > > > > [+Ard] > > > > On Mon, Apr 26, 2021 at 02:57:33AM +0900, Masahiro Yamada wrote: > > > Generate *.S by Perl like arch/{mips,x86}/crypto/Makefile. > > > > > > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> > > > --- > > > > > > arch/arm64/crypto/Makefile | 9 +- > > > arch/arm64/crypto/poly1305-core.S_shipped | 835 --------- > > > arch/arm64/crypto/sha256-core.S_shipped | 2069 --------------------- > > > arch/arm64/crypto/sha512-core.S_shipped | 1093 ----------- > > > 4 files changed, 3 insertions(+), 4003 deletions(-) > > > delete mode 100644 arch/arm64/crypto/poly1305-core.S_shipped > > > delete mode 100644 arch/arm64/crypto/sha256-core.S_shipped > > > delete mode 100644 arch/arm64/crypto/sha512-core.S_shipped > > > > What's the advantage of removing the _shipped files? We included them > > originally so that we didn't require perl for the kernel build -- is that no > > longer an issue? > > > > I guess I'm just missing the justification for the change. > > Removing 4000 lines of code is an improvement in itself, I suppose, > but I have no preference either way,
If necessary, I can send v2 with the following info added.
------------------------------>8--------------------------------- People building the arm64 kernel are likely to have Perl already installed on the system.
ARCH=arm64 defconfig sets CONFIG_OID_REGISTRY=y, so Perl is required to generate lib/oid_registery_data.c anyway.
Also, Documentation/process/changes.rst says:
You will need perl 5 and the following modules: ``Getopt::Long``, ``Getopt::Std``, ``File::Basename``, and ``File::Find`` to build the kernel. ------------------------------>8---------------------------------
-- Best Regards Masahiro Yamada
| |