Messages in this thread | | | Date | Mon, 26 Apr 2021 12:18:55 +0300 | From | Sakari Ailus <> | Subject | Re: [Outreachy kernel] [PATCH v3] staging: media: atomisp: pci: Change line break to avoid an open parenthesis at the end of the line |
| |
On Wed, Apr 21, 2021 at 02:15:22PM +0100, Matthew Wilcox wrote: > On Wed, Apr 21, 2021 at 09:37:18AM -0300, Aline Santana Cordeiro wrote: > > -const struct atomisp_format_bridge *get_atomisp_format_bridge_from_mbus( > > - u32 mbus_code); > > +const struct atomisp_format_bridge * > > +get_atomisp_format_bridge_from_mbus(u32 mbus_code); > > As I said, better to break the 80 column rule than do this.
May depend on the maintainer, as well as other reviewers. It's a question of priorities.
I'd suggest otherwise.
-- Sakari Ailus
| |