Messages in this thread | | | Date | Mon, 26 Apr 2021 10:09:26 +0200 | From | Greg KH <> | Subject | Re: [PATCH 2/2] tty: serial: fsl_lpuart: fix the potential bug of dereference null return value |
| |
On Mon, Apr 26, 2021 at 03:49:35PM +0800, Sherry Sun wrote: > This issue is reported by Coverity Check. > In lpuart_probe, return value of function which returns null is > dereferenced without checking. > > Signed-off-by: Sherry Sun <sherry.sun@nxp.com> > --- > drivers/tty/serial/fsl_lpuart.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c > index 777d54b593f8..c95e71fd2ca0 100644 > --- a/drivers/tty/serial/fsl_lpuart.c > +++ b/drivers/tty/serial/fsl_lpuart.c > @@ -2589,6 +2589,9 @@ static int lpuart_probe(struct platform_device *pdev) > struct resource *res; > int ret; > > + if (!sdata) > + return -ENODEV;
How can sdata be NULL?
thanks,
greg k-h
| |