lkml.org 
[lkml]   [2021]   [Apr]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 30/37] HID: alps: fix error return code in alps_input_configured()
    Date
    From: Jia-Ju Bai <baijiaju1990@gmail.com>

    [ Upstream commit fa8ba6e5dc0e78e409e503ddcfceef5dd96527f4 ]

    When input_register_device() fails, no error return code is assigned.
    To fix this bug, ret is assigned with -ENOENT as error return code.

    Reported-by: TOTE Robot <oslab@tsinghua.edu.cn>
    Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
    Signed-off-by: Jiri Kosina <jkosina@suse.cz>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/hid/hid-alps.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/hid/hid-alps.c b/drivers/hid/hid-alps.c
    index ed9c0ea5b026..1bc6ad0339d2 100644
    --- a/drivers/hid/hid-alps.c
    +++ b/drivers/hid/hid-alps.c
    @@ -429,6 +429,7 @@ static int alps_input_configured(struct hid_device *hdev, struct hid_input *hi)
    ret = input_register_device(data->input2);
    if (ret) {
    input_free_device(input2);
    + ret = -ENOENT;
    goto exit;
    }
    }
    --
    2.30.2


    \
     
     \ /
      Last update: 2021-04-26 09:36    [W:3.269 / U:0.736 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site