Messages in this thread | | | Subject | Re: [PATCH 1/2] cpupower: Fix amd cpu (family < 0x17) active state issue | From | 徐福海 <> | Date | Sun, 25 Apr 2021 10:41:40 +0800 |
| |
okay, I believe the two patches are for fixing defferent issue, I will update my patches as your mention
THANKS
在 2021/4/24 上午6:26, Shuah Khan 写道: > On 4/19/21 8:27 PM, 徐福海 wrote: >> From: xufuhai<xufuhai@kuaishou.com> >> >> For the old AMD processor (family < 0x17), cpupower will call the >> amd_pci_get_num_boost_states function, but for the non-root user >> pci_read_byte function (implementation comes from the psutil library), >> val will be set to 0xff, indicating that there is no read function >> callback. At this time, the original logic will set the cpupower turbo >> active state to yes. This is an obvious issue~ >> >> Reproduce procedure: >> cpupower frequency-info >> >> Reported-by: yangrui<yangrui@kuaishou.com> >> Signed-off-by: xufuhai<xufuhai@kuaishou.com> > > Also your Signed-off-by should match the from address. > There is a mismatch between the two. > >> Signed-off-by: chenguanqiao<chenguanqiao@kuaishou.com> >> Signed-off-by: lishujin<lishujin@kuaishou.com> >> Reviewed-by: Thomas Renninger<trenn@suse.com> >> --- >> tools/power/cpupower/utils/helpers/amd.c | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/tools/power/cpupower/utils/helpers/amd.c b/tools/power/cpupower/utils/helpers/amd.c >> index 97f2c857048e..6f9504906afa 100644 >> --- a/tools/power/cpupower/utils/helpers/amd.c >> +++ b/tools/power/cpupower/utils/helpers/amd.c >> @@ -137,6 +137,13 @@ int amd_pci_get_num_boost_states(int *active, int *states) >> return -ENODEV; >> val = pci_read_byte(device, 0x15c); >> + >> + /* If val is 0xff, meaning has no permisson to >> + * get the boost states, return -1 >> + */ >> + if (val == 0xff) >> + return -1; >> + >> if (val & 3) >> *active = 1; >> else >> -- >> 2.24.3 (Apple Git-128) >> > > I am seeing two patches with the same commit summary, > should these two be a singles patch? > > https://patchwork.kernel.org/project/linux-pm/patch/6e35df20-753a-6c9c-8786-3fc87cdd17ba@gmail.com/ > > Please combine the two and send single patch if they fix the > same problem. If not, please change the commit log to reflect > the difference. > > thanks, > -- Shuah > >
| |