lkml.org 
[lkml]   [2021]   [Apr]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 05/78] media: mdk-mdp: fix pm_runtime_get_sync() usage count
    From
    Date
    Hi Mauro,

    On Sat, 2021-04-24 at 08:44 +0200, Mauro Carvalho Chehab wrote:
    > The pm_runtime_get_sync() internally increments the
    > dev->power.usage_count without decrementing it, even on errors.
    > replace it by the new pm_runtime_resume_and_get(), introduced by:
    > commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter")
    > in order to properly decrement the usage counter and avoid memory
    > leaks.
    >
    > While here, check if the PM runtime was caught during
    > chipset probing time.
    >
    > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
    > ---
    >  drivers/media/platform/rockchip/rga/rga.c | 4 +++-
    >  1 file changed, 3 insertions(+), 1 deletion(-)
    >

    The commit log "media" mdk-mdp" is wrong here.

    Maybe you can squash this commit with media: rga-buf: use pm_runtime_resume_and_get()?

    Thanks,
    Ezequiel

    \
     
     \ /
      Last update: 2021-04-24 20:24    [W:4.022 / U:0.152 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site