lkml.org 
[lkml]   [2021]   [Apr]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v9 1/8] pwm: pca9685: Switch to atomic API
On Thu, Apr 22, 2021 at 01:39:01PM +0200, Clemens Gruber wrote:
> On Sat, Apr 17, 2021 at 09:51:50PM +0200, Uwe Kleine-König wrote:
> > On Thu, Apr 15, 2021 at 02:14:48PM +0200, Clemens Gruber wrote:
> > > The switch to the atomic API goes hand in hand with a few fixes to
> > > previously experienced issues:
> > > - The duty cycle is no longer lost after disable/enable (previously the
> > > OFF registers were cleared in disable and the user was required to
> > > call config to restore the duty cycle settings)
> > > - If one sets a period resulting in the same prescale register value,
> > > the sleep and write to the register is now skipped
> > > - Previously, only the full ON bit was toggled in GPIO mode (and full
> > > OFF cleared if set to high), which could result in both full OFF and
> > > full ON not being set and on=0, off=0, which is not allowed according
> > > to the datasheet
> > > - The OFF registers were reset to 0 in probe, which could lead to the
> > > forbidden on=0, off=0. Fixed by resetting to POR default (full OFF)
> > >
> > > Signed-off-by: Clemens Gruber <clemens.gruber@pqgruber.com>
> >
> > (I sent my ack to v8 before, but indeed this was the version I intended
> > to ack)
> >
> > Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>
> Thierry: Do you think we can get patches 1 to 3 into 5.13-rc1?

Applied patches 1-3, thanks.

Thierry
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2021-04-23 18:47    [W:0.045 / U:0.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site