Messages in this thread | | | Subject | Re: [PATCH][next] drm/amdkfd: remove redundant initialization to variable r | From | Felix Kuehling <> | Date | Thu, 22 Apr 2021 15:43:50 -0400 |
| |
Am 2021-04-22 um 8:44 a.m. schrieb Colin King: > From: Colin Ian King <colin.king@canonical.com> > > The variable r is being initialized with a value that is never read > and it is being updated later with a new value. The initialization is > redundant and can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King <colin.king@canonical.com> Applied to amd-staging-drm-next.
Thanks, Felix
> --- > drivers/gpu/drm/amd/amdkfd/kfd_migrate.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_migrate.c b/drivers/gpu/drm/amd/amdkfd/kfd_migrate.c > index d44a46eb00d6..a66b67083d83 100644 > --- a/drivers/gpu/drm/amd/amdkfd/kfd_migrate.c > +++ b/drivers/gpu/drm/amd/amdkfd/kfd_migrate.c > @@ -303,7 +303,7 @@ svm_migrate_copy_to_vram(struct amdgpu_device *adev, struct svm_range *prange, > uint64_t vram_addr; > uint64_t offset; > uint64_t i, j; > - int r = -ENOMEM; > + int r; > > pr_debug("svms 0x%p [0x%lx 0x%lx]\n", prange->svms, prange->start, > prange->last);
| |