lkml.org 
[lkml]   [2021]   [Apr]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH] net: mana: fix PCI_HYPERV dependency
Date
> From: Arnd Bergmann <arnd@kernel.org>
> Sent: Thursday, April 22, 2021 6:35 AM
> ...
> From: Arnd Bergmann <arnd@arndb.de>
>
> The MANA driver causes a build failure in some configurations when
> it selects an unavailable symbol:
>
> WARNING: unmet direct dependencies detected for PCI_HYPERV
> Depends on [n]: PCI [=y] && X86_64 [=y] && HYPERV [=n] && PCI_MSI [=y]
> && PCI_MSI_IRQ_DOMAIN [=y] && SYSFS [=y]
> Selected by [y]:
> - MICROSOFT_MANA [=y] && NETDEVICES [=y] && ETHERNET [=y] &&
> NET_VENDOR_MICROSOFT [=y] && PCI_MSI [=y] && X86_64 [=y]
> drivers/pci/controller/pci-hyperv.c: In function 'hv_irq_unmask':
> drivers/pci/controller/pci-hyperv.c:1217:9: error: implicit declaration of
> function 'hv_set_msi_entry_from_desc'
> [-Werror=implicit-function-declaration]
> 1217 |
> hv_set_msi_entry_from_desc(&params->int_entry.msi_entry, msi_desc);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~
>
> A PCI driver should never depend on a particular host bridge
> implementation in the first place, but if we have this dependency
> it's better to express it as a 'depends on' rather than 'select'.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Reviewed-by: Dexuan Cui <decui@microsoft.com>

\
 
 \ /
  Last update: 2021-04-22 19:29    [W:0.234 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site