lkml.org 
[lkml]   [2021]   [Apr]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] Input: rework USB Kconfig dependencies
From
Date
On 4/22/21 6:36 AM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> A lot of input drivers traditionally depend on CONFIG_USB_ARCH_HAS_HCD
> and select CONFIG_USB. This works but is different from almost every
> other subsystem in the kernel.
>
> I found this when debugging a build failure in the RC subsystem that
> had the same logic.
>
> The problem here is that CONFIG_USB_ARCH_HAS_HCD no longer has
> a meaning since the host controller support has been changed to
> use machine specific loadable modules for the USB host. Selecting
> a subsystem that a driver needs is confusing and can lead to
> recursive dependency chains in Kconfig.
>
> In both cases, the normal logic is to specify 'depends on USB'.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Reviewed-by: Randy Dunlap <rdunlap@infradead.org>

Thanks.

> ---
> drivers/input/joystick/Kconfig | 6 ++----
> drivers/input/misc/Kconfig | 15 +++++----------
> drivers/input/mouse/Kconfig | 9 +++------
> drivers/input/tablet/Kconfig | 15 +++++----------
> drivers/input/touchscreen/Kconfig | 3 +--
> 5 files changed, 16 insertions(+), 32 deletions(-)
>


--
~Randy

\
 
 \ /
  Last update: 2021-04-22 18:33    [W:0.042 / U:1.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site