Messages in this thread | | | Date | Thu, 22 Apr 2021 11:46:29 -0400 | From | Steven Rostedt <> | Subject | Re: [PATCH 1/1] sched: remove the redundant 'success' in the sched tracepoint |
| |
On Thu, 22 Apr 2021 20:22:26 +0800 Ed Tsai <ed.tsai@mediatek.com> wrote:
> 'success' is left here for a long time and also it is meaningless > for the upper user. Just remove it.
Have you tested all userspace code that might use this?
This is the "poster boy" example of why Peter Zijlstra hates trace events ;-)
I know I've updated trace-cmd to check to see if this field exits before depending on it, but there may be some other tools that may not. Perhaps nothing will break.
I'm all for this change, but be ware, it might be reverted if there's some tool out that that expects it to exist. This is why it hasn't been removed.
-- Steve
| |