Messages in this thread | | | Date | Thu, 22 Apr 2021 18:14:51 +0300 | From | Vladimir Oltean <> | Subject | Re: [PATCH] [net-next] net: enetc: fix link error again |
| |
On Thu, Apr 22, 2021 at 03:35:11PM +0200, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@arndb.de> > > A link time bug that I had fixed before has come back now that > another sub-module was added to the enetc driver: > > ERROR: modpost: "enetc_ierb_register_pf" [drivers/net/ethernet/freescale/enetc/fsl-enetc.ko] undefined! > > The problem is that the enetc Makefile is not actually used for > the ierb module if that is the only built-in driver in there > and everything else is a loadable module. > > Fix it by always entering the directory this time, regardless > of which symbols are configured. This should reliably fix the > problem and prevent it from coming back another time. > > Fixes: 112463ddbe82 ("net: dsa: felix: fix link error") > Fixes: e7d48e5fbf30 ("net: enetc: add a mini driver for the Integrated Endpoint Register Block") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > drivers/net/ethernet/freescale/Makefile | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/net/ethernet/freescale/Makefile b/drivers/net/ethernet/freescale/Makefile > index 67c436400352..de7b31842233 100644 > --- a/drivers/net/ethernet/freescale/Makefile > +++ b/drivers/net/ethernet/freescale/Makefile > @@ -24,6 +24,4 @@ obj-$(CONFIG_FSL_DPAA_ETH) += dpaa/ > > obj-$(CONFIG_FSL_DPAA2_ETH) += dpaa2/ > > -obj-$(CONFIG_FSL_ENETC) += enetc/ > -obj-$(CONFIG_FSL_ENETC_MDIO) += enetc/ > -obj-$(CONFIG_FSL_ENETC_VF) += enetc/ > +obj-y += enetc/ > -- > 2.29.2 >
I feel so bad that I'm incapable of troubleshooting even the most elementary Kconfig issues... I did not even once think of opening that Makefile.
Acked-by: Vladimir Oltean <vladimir.oltean@nxp.com>
| |