lkml.org 
[lkml]   [2021]   [Apr]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH][next] wireless: wext-spy: Fix out-of-bounds warning
From
Date
On Wed, 2021-04-21 at 18:43 -0500, Gustavo A. R. Silva wrote:
>
>   /* Just do it */
> - memcpy(&(spydata->spy_thr_low), &(threshold->low),
> - 2 * sizeof(struct iw_quality));
> + memcpy(&spydata->spy_thr_low, &threshold->low, sizeof(threshold->low));
> + memcpy(&spydata->spy_thr_high, &threshold->high, sizeof(threshold->high));
>

It would've been really simple to stick to 80 columns here (and
everywhere in the patch), please do that.

Also, why not just use struct assigments?

spydata->spy_thr_low = threshold->low;

etc.

Seems far simpler (and shorter lines).

johannes


\
 
 \ /
  Last update: 2021-04-22 09:05    [W:0.081 / U:0.444 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site