Messages in this thread | | | Subject | Re: [PATCH][next] wireless: wext-spy: Fix out-of-bounds warning | From | Johannes Berg <> | Date | Thu, 22 Apr 2021 09:04:19 +0200 |
| |
On Wed, 2021-04-21 at 18:43 -0500, Gustavo A. R. Silva wrote: > > /* Just do it */ > - memcpy(&(spydata->spy_thr_low), &(threshold->low), > - 2 * sizeof(struct iw_quality)); > + memcpy(&spydata->spy_thr_low, &threshold->low, sizeof(threshold->low)); > + memcpy(&spydata->spy_thr_high, &threshold->high, sizeof(threshold->high)); >
It would've been really simple to stick to 80 columns here (and everywhere in the patch), please do that.
Also, why not just use struct assigments?
spydata->spy_thr_low = threshold->low;
etc.
Seems far simpler (and shorter lines).
johannes
| |