Messages in this thread | | | Subject | Re: [PATCH 3/5] tools headers x86: Copy cpuid helpers from the kernel | From | Paolo Bonzini <> | Date | Thu, 22 Apr 2021 08:59:50 +0200 |
| |
On 22/04/21 02:56, Ricardo Koller wrote: > Copy arch/x86/include/asm/acpufeature.h and arch/x86/kvm/reverse_cpuid.h > from the kernel so that KVM selftests can use them in the next commits. > Also update the tools copy of arch/x86/include/asm/acpufeatures.h.
Typo.
> These should be kept in sync, ideally with the help of some script like > check-headers.sh used by tools/perf/.
Please provide such a script.
Also, without an automated way to keep them in sync I think it's better to copy all of them to tools/testing/selftests/kvm, so that we can be sure that a maintainer (me) runs the script and keeps them up to date. I am fairly sure that the x86 maintainers don't want to have anything to do with all of this business!
Paolo
| |