lkml.org 
[lkml]   [2021]   [Apr]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 1/1] dmaengine: idxd: Add IDXD performance monitor support
On 21-04-21, 07:50, Zanussi, Tom wrote:

> > > > > +static ssize_t cpumask_show(struct device *dev, struct device_attribute *attr,
> > > > > + char *buf);
> > > > > +
> > > > > +static cpumask_t perfmon_dsa_cpu_mask;
> > > > > +static bool cpuhp_set_up;
> > > > > +static enum cpuhp_state cpuhp_slot;
> > > > > +
> > > > > +static DEVICE_ATTR_RO(cpumask);
> > > >
> > > > Pls document these new attributes added
> >
> > ?
> >
>
> Yes, I'll add comments to all the attributes (also I'm assuming they don't need to be documented elsewhere).

They need to be, all new sysfs attributes are ABI and need to be
documented in Documentation/ABI/

Thanks
--
~Vinod

\
 
 \ /
  Last update: 2021-04-21 17:06    [W:0.044 / U:0.364 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site