lkml.org 
[lkml]   [2021]   [Apr]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 5/7] KVM: SVM: hyper-v: Remote TLB flush for SVM
From
Date

On 4/16/2021 1:26 PM, Vineeth Pillai wrote:
>
>>
>>   +#if IS_ENABLED(CONFIG_HYPERV)
>> +static void hv_init_vmcb(struct vmcb *vmcb)
>> +{
>> +    struct hv_enlightenments *hve = &vmcb->hv_enlightenments;
>> +
>> +    if (npt_enabled &&
>> +        ms_hyperv.nested_features & HV_X64_NESTED_ENLIGHTENED_TLB)
>> Nitpick: we can probably have a 'static inline' for
>>
>>   "npt_enabled && ms_hyperv.nested_features &
>> HV_X64_NESTED_ENLIGHTENED_TLB"
>>
>> e.g. 'hv_svm_enlightened_tlbflush()'
> Makes sense, will do.
On a second thought, this function itself is small and just does this
one check.
So, might not make sense to add one more function. I shall rather change
this
function to be an inline.

Thanks,
Vineeth

\
 
 \ /
  Last update: 2021-04-21 16:04    [W:0.054 / U:0.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site