lkml.org 
[lkml]   [2021]   [Apr]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v1] net: Qcom WWAN control driver: fix the rx_budget was eaten incorrectly
Hi Jarvis,

On Wed, 21 Apr 2021 at 05:57, Jarvis Jiang <jarvis.w.jiang@gmail.com> wrote:
>
> mhi_wwan_rx_budget_dec() should check the value of mhiwwan->rx_budget
> before the decrement, not the value after decrement.
>
> When mhiwwan->rx_budget = 1, mhi_wwan_rx_budget_dec() will always return
> false, which will cause the mhi_wwan_ctrl_refill_work() not to queue rx
> buffers to transfer ring any more, and rx will be stuck.
>
> This patch was tested with Ubuntu 20.04 X86_64 PC as host
>
> Signed-off-by: Jarvis Jiang <jarvis.w.jiang@gmail.com>

Thanks for the patch, but a similar change for this issue has just
been merged in net-next (a926c025d56b net: wwan: mhi_wwan_ctrl: Fix RX
buffer starvation).

Regards,
Loic

\
 
 \ /
  Last update: 2021-04-21 08:38    [W:0.033 / U:0.208 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site