Messages in this thread | | | Date | Wed, 21 Apr 2021 11:18:43 +0200 | From | Thomas Bogendoerfer <> | Subject | Re: [PATCH 1/2] gpio: Add support for IDT 79RC3243x GPIO controller |
| |
On Wed, Apr 21, 2021 at 11:48:59AM +0300, Andy Shevchenko wrote: > On Wed, Apr 21, 2021 at 11:32 AM Thomas Bogendoerfer > <tsbogend@alpha.franken.de> wrote: > > On Wed, Apr 21, 2021 at 11:09:51AM +0300, Andy Shevchenko wrote: > > > On Tuesday, April 20, 2021, Thomas Bogendoerfer <tsbogend@alpha.franken.de> > > > wrote: > > > > > > > IDT 79RC3243x SoCs integrated a gpio controller, which handles up > > > > to 32 gpios. All gpios could be used as interrupt source. > > > > > > > > > > > > I would recommend looking for latest new drivers in GPIO subsystem to see > > > how you may improve yours. > > > > Could give me a better pointer to it ? I looked at a lot of gpio driver > > and took what fitted best. > > > > > Here just one question, why it can not be a module > > > > that's probably doable... > > > > > why arch_initcall() is used > > > > without that interrupts weren't avaiable early enough. > > > > > and why you put a dead code into it (see the first part of the > > > question)? > > > > hmm, pointer please ? > > It's already in the question above, do your homework :-)
is this some sort of joke I'm not getting ?
git log --oneline drivers/gpio/Makefile
2ad74f40dacc gpio: visconti: Add Toshiba Visconti GPIO support
that's the latest driver added in v5.12-rc8. Is that a good one ?
Thomas.
-- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]
| |