Messages in this thread | | | Subject | Re: [PATCH v2] media: rkisp1: rkisp1-params.c: Fix typos | From | Dafna Hirschfeld <> | Date | Wed, 21 Apr 2021 11:09:01 +0200 |
| |
Hi, Thanks for the fix,
On 20.04.21 19:45, Sebastian Fricke wrote: > s/when the camera active/when the camera is active/ > s/thus not isr protection/therefore there is no need to acquire a lock/ > > Signed-off-by: Sebastian Fricke <sebastian.fricke@posteo.net>
Reviewed-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
> --- > drivers/media/platform/rockchip/rkisp1/rkisp1-params.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-params.c b/drivers/media/platform/rockchip/rkisp1/rkisp1-params.c > index b6beddd988d0..529c6e21815f 100644 > --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-params.c > +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-params.c > @@ -1258,7 +1258,10 @@ void rkisp1_params_configure(struct rkisp1_params *params, > rkisp1_params_config_parameter(params); > } > > -/* Not called when the camera active, thus not isr protection. */ > +/* > + * Not called when the camera is active, therefore there is no need to acquire > + * a lock. > + */ > void rkisp1_params_disable(struct rkisp1_params *params) > { > rkisp1_param_clear_bits(params, RKISP1_CIF_ISP_DPCC_MODE, >
| |