Messages in this thread | | | Subject | Re: [PATCH RESEND][next] rxrpc: Fix fall-through warnings for Clang | From | Jeffrey E Altman <> | Date | Wed, 21 Apr 2021 19:41:56 -0400 |
| |
On 3/5/2021 4:19 AM, Gustavo A. R. Silva (gustavoars@kernel.org) wrote: > In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning > by explicitly adding a break statement instead of letting the code fall > through to the next case. > > Link: https://github.com/KSPP/linux/issues/115 > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
This change looks good to me. Although I would also be happy with a fallthrough statement being added instead.
Reviewed-by: Jeffrey Altman <jaltman@auristor.com>
begin:vcard fn:Jeffrey Altman n:Altman;Jeffrey org:AuriStor, Inc. adr:;;255 W 94TH ST STE 6B;New York;NY;10025-6985;United States email;internet:jaltman@auristor.com title:CEO tel;work:+1-212-769-9018 url:https://www.linkedin.com/in/jeffreyaltman/ version:2.1 end:vcard
[unhandled content-type:application/pgp-signature] | |