Messages in this thread | | | Date | Wed, 21 Apr 2021 10:46:11 +0300 | From | Eli Cohen <> | Subject | Re: [PATCH 5/7] virito_pci libray: hide vp_modern_map_capability() |
| |
On Thu, Apr 15, 2021 at 03:31:45AM -0400, Jason Wang wrote: > No user now and the capability should not be setup > externally. Instead, every access to the capability should be done via > virtio_pci_modern_device. > > Signed-off-by: Jason Wang <jasowang@redhat.com>
Reviewed-by: Eli Cohen <elic@nvidia.com>
> --- > drivers/virtio/virtio_pci_modern_dev.c | 10 ++++------ > include/linux/virtio_pci_modern.h | 5 ----- > 2 files changed, 4 insertions(+), 11 deletions(-) > > diff --git a/drivers/virtio/virtio_pci_modern_dev.c b/drivers/virtio/virtio_pci_modern_dev.c > index 5a657e56b46d..9c241c9bd920 100644 > --- a/drivers/virtio/virtio_pci_modern_dev.c > +++ b/drivers/virtio/virtio_pci_modern_dev.c > @@ -16,11 +16,10 @@ > * > * Returns the io address of for the part of the capability > */ > -void __iomem *vp_modern_map_capability(struct virtio_pci_modern_device *mdev, int off, > - size_t minlen, > - u32 align, > - u32 start, u32 size, > - size_t *len) > +static void __iomem * > +vp_modern_map_capability(struct virtio_pci_modern_device *mdev, int off, > + size_t minlen, u32 align, u32 start, u32 size, > + size_t *len) > { > struct pci_dev *dev = mdev->pci_dev; > u8 bar; > @@ -90,7 +89,6 @@ void __iomem *vp_modern_map_capability(struct virtio_pci_modern_device *mdev, in > length, offset, bar); > return p; > } > -EXPORT_SYMBOL_GPL(vp_modern_map_capability); > > /** > * virtio_pci_find_capability - walk capabilities to find device info. > diff --git a/include/linux/virtio_pci_modern.h b/include/linux/virtio_pci_modern.h > index 179a2fb4bf37..e6e7072413c1 100644 > --- a/include/linux/virtio_pci_modern.h > +++ b/include/linux/virtio_pci_modern.h > @@ -99,11 +99,6 @@ void vp_modern_set_queue_size(struct virtio_pci_modern_device *mdev, > u16 vp_modern_get_queue_size(struct virtio_pci_modern_device *mdev, > u16 idx); > u16 vp_modern_get_num_queues(struct virtio_pci_modern_device *mdev); > -void __iomem *vp_modern_map_capability(struct virtio_pci_modern_device *mdev, int off, > - size_t minlen, > - u32 align, > - u32 start, u32 size, > - size_t *len); > void *vp_modern_map_vq_notify(struct virtio_pci_modern_device *mdev, > u16 index); > int vp_modern_probe(struct virtio_pci_modern_device *mdev); > -- > 2.18.1 >
| |