Messages in this thread | | | From | Arnd Bergmann <> | Date | Wed, 21 Apr 2021 21:27:46 +0200 | Subject | Re: [PATCH] memstick: r592: ignore kfifo_out() return code again |
| |
On Wed, Apr 21, 2021 at 7:17 PM 'Nick Desaulniers' via Clang Built Linux <clang-built-linux@googlegroups.com> wrote: > On Wed, Apr 21, 2021 at 6:52 AM Arnd Bergmann <arnd@kernel.org> wrote:
> > The value was never checked here, and the purpose of the function > > is only to flush the contents, so restore the old behavior but > > add a cast to void and a comment, which hopefully warns with neither > > gcc nor clang now. > > > > If anyone has an idea for how to fix it without ignoring the return > > code, that is probably better. > > Should r592_flush_fifo_write be made to return an int, then callers of > r592_flush_fifo_write percolate up their return code? > r592_transfer_fifo_pio() seems to only return 0, but its callers are > doing return code checking.
I looked into that but couldn't come up with anything useful to do with the return code in the callers. kfifo_out() itself doesn't seem to ever return an error but only the length.
Arnd
| |