Messages in this thread | | | Subject | Re: [PATCH 4/4] x86/speculation: Add PSF mitigation kernel parameters | From | "Saripalli, RK" <> | Date | Wed, 21 Apr 2021 13:55:03 -0500 |
| |
On 4/21/2021 1:48 PM, Borislav Petkov wrote: > On Wed, Apr 21, 2021 at 02:32:13PM -0400, Bandan Das wrote: >> Maybe, rename the parameter to something like psfd_disable, then off >> -> disables mitigation and on -> enables it. Or just rewriting this to >> off -> turns off predictive store forwarding is probably ok too. > > Yes: > > off - Turns off predictive store forwarding. > on - Turns on... > > Ramakrishna, you don't have to call this a mitigation - this is a flag > which controls the feature.
Agreed. I will fix it. > > Also, those 4 patches can be merged into a single one which simply adds > the feature along with the boot-time controls.
I separated them into separate patches because the KVM patch depends on one of the patch. The corresponding QEMU patch depends on another patch.
By separating them into 4 separate patches, my thinking was I could keep them logically separate. Yes, I can combine all 4 patches into one patch but would like to get feedback before I do so. > > Thx. >
| |