Messages in this thread | | | Date | Tue, 20 Apr 2021 18:47:03 +0000 | From | Luis Chamberlain <> | Subject | Re: [RFC v2 6/6] fs: add automatic kernel fs freeze / thaw and remove kthread freezing |
| |
On Tue, Apr 20, 2021 at 01:59:03PM +0100, Christoph Hellwig wrote: > > This also removes all the superflous freezer calls on all filesystems > > as they are no longer needed as the VFS now performs filesystem > > freezing/thaw if the filesystem has support for it. The filesystem > > therefore is in charge of properly dealing with quiescing of the > > filesystem through its callbacks. > > Can you split that out from the main logic change? Maybe even into one > patch per file system?
The issue with this is that once you do the changes in pm to freeze/suspend, if you leave the other changes in for the filesystems freeze / resume will stall, so all this needs to be an atomic operation if we want bisectable kernels.
Luis
| |